webui: add support for jsonl/ndjson file diffing as text files #8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change follows the approach taken for other similar formats, allowing newline-delimited JSON files to be viewed and diffed in the LakeFS UI. Closes treeverse#8094
|
|
itaiad200
added
the
include-changelog
|
Hi @itaiad200, what's left to get this merged in? |
|
Forcing this merge since contributors' PRs by default do not run all required status checks. I ran them offline and they passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Closes #8094
This change follows the approach taken for other similar formats, allowing newline-delimited JSON files to be viewed and diffed in the LakeFS UI.
Background
Share context and relevant information for the PR: offline discussions, considerations, design decisions etc.
newline-delimited JSON is a useful format for human-readable representation of data. The goal of this change is to allow is to be viewed and diffed in the LakeFS UI.
First discussed in Slack here: https://lakefs.slack.com/archives/C016726JLJW/p1724354587851009
New Feature
If this PR introduces a new feature, describe it here.
Testing Details
How were the changes tested?
I ran
make build-dockerlocally along with:Then uploaded a basic JSONL file to a repo, as well as a modified version of it that adds a lineL
Breaking Change?
Does this change break any existing functionality? (API, CLI, Clients)
Nope!
Additional info
Logs, outputs, screenshots of changes if applicable (CLI / GUI changes)
lmk if relevant.
Contact Details
How can we get in touch with you if we need more info? (ex. email@example.com)
Happy to respond in this issue or the Slack thread!